win: Dynamically disable WoW64 tests absent explicit 32-bit build output
Rather than having the 64-bit build assume that it lives in
out\{Debug,Release}_x64 and that it can find 32-bit build output in
out\{Debug,Release}, require the location of 32-bit build output to be
provided explicitly via the CRASHPAD_TEST_32_BIT_OUTPUT environment
variable. If this variable is not set, 64-bit tests that require 32-bit
test build output will dynamically disable themselves at runtime.
In order for this to work, a new DISABLED_TEST() macro is added to
support dynamically disabled tests. gtest does not have its own
first-class support for this
(https://groups.google.com/d/topic/googletestframework/Nwh3u7YFuN4,
https://github.com/google/googletest/issues/490) so this local solution
is used instead.
For tests via Crashpad’s own build\run_tests.py, which is how Crashpad’s
own buildbots and trybots invoke tests, CRASHPAD_TEST_32_BIT_OUTPUT is
set to a locaton compatible with the paths expected for the GYP-based
build. No test coverage is lost on Crashpad’s own buildbots and trybots.
For Crashpad tests in Chromium’s buildbots and trybots, this environment
variable will not be set, causing these tests to be dynamically
disabled.
Bug: crashpad:203, chromium:743139, chromium:777924
Change-Id: I3c0de2bf4f835e13ed5a4adda5760d6fed508126
Reviewed-on: https://chromium-review.googlesource.com/739795
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-10-26 13:48:01 -04:00
|
|
|
|
// Copyright 2017 The Crashpad Authors. All rights reserved.
|
|
|
|
|
//
|
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
|
//
|
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
//
|
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
|
// limitations under the License.
|
|
|
|
|
|
|
|
|
|
#ifndef CRASHPAD_TEST_GTEST_DISABLED_H_
|
|
|
|
|
#define CRASHPAD_TEST_GTEST_DISABLED_H_
|
|
|
|
|
|
|
|
|
|
#include <string>
|
2017-10-26 18:37:49 -04:00
|
|
|
|
#include <vector>
|
win: Dynamically disable WoW64 tests absent explicit 32-bit build output
Rather than having the 64-bit build assume that it lives in
out\{Debug,Release}_x64 and that it can find 32-bit build output in
out\{Debug,Release}, require the location of 32-bit build output to be
provided explicitly via the CRASHPAD_TEST_32_BIT_OUTPUT environment
variable. If this variable is not set, 64-bit tests that require 32-bit
test build output will dynamically disable themselves at runtime.
In order for this to work, a new DISABLED_TEST() macro is added to
support dynamically disabled tests. gtest does not have its own
first-class support for this
(https://groups.google.com/d/topic/googletestframework/Nwh3u7YFuN4,
https://github.com/google/googletest/issues/490) so this local solution
is used instead.
For tests via Crashpad’s own build\run_tests.py, which is how Crashpad’s
own buildbots and trybots invoke tests, CRASHPAD_TEST_32_BIT_OUTPUT is
set to a locaton compatible with the paths expected for the GYP-based
build. No test coverage is lost on Crashpad’s own buildbots and trybots.
For Crashpad tests in Chromium’s buildbots and trybots, this environment
variable will not be set, causing these tests to be dynamically
disabled.
Bug: crashpad:203, chromium:743139, chromium:777924
Change-Id: I3c0de2bf4f835e13ed5a4adda5760d6fed508126
Reviewed-on: https://chromium-review.googlesource.com/739795
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-10-26 13:48:01 -04:00
|
|
|
|
|
|
|
|
|
#include "base/macros.h"
|
|
|
|
|
#include "gtest/gtest.h"
|
|
|
|
|
|
|
|
|
|
//! \file
|
|
|
|
|
|
|
|
|
|
namespace crashpad {
|
|
|
|
|
namespace test {
|
|
|
|
|
|
|
|
|
|
//! \brief Provides support for dynamically disabled gtest tests.
|
|
|
|
|
//!
|
|
|
|
|
//! A test runner must register this with gtest as follows prior to calling
|
|
|
|
|
//! `RUN_ALL_TESTS()`:
|
|
|
|
|
//! \code
|
|
|
|
|
//! testing::AddGlobalTestEnvironment(
|
|
|
|
|
//! crashpad::test::DisabledTestGtestEnvironment::Get());
|
|
|
|
|
//! \endcode
|
|
|
|
|
class DisabledTestGtestEnvironment final : public testing::Environment {
|
|
|
|
|
public:
|
|
|
|
|
//! \brief Returns the DisabledTestGtestEnvironment singleton instance,
|
|
|
|
|
//! creating it if necessary.
|
|
|
|
|
static DisabledTestGtestEnvironment* Get();
|
|
|
|
|
|
|
|
|
|
//! \brief Displays a message about a test being disabled, and arranges for
|
|
|
|
|
//! this information to be duplicated in TearDown().
|
|
|
|
|
//!
|
|
|
|
|
//! This method is for the internal use of the DISABLED_TEST() macro. Do not
|
|
|
|
|
//! call it directly, use the macro instead.
|
|
|
|
|
void DisabledTest();
|
|
|
|
|
|
|
|
|
|
private:
|
|
|
|
|
DisabledTestGtestEnvironment();
|
|
|
|
|
~DisabledTestGtestEnvironment() override;
|
|
|
|
|
|
|
|
|
|
// testing::Environment:
|
|
|
|
|
void TearDown() override;
|
|
|
|
|
|
2017-10-26 18:37:49 -04:00
|
|
|
|
std::vector<std::string> disabled_tests_;
|
win: Dynamically disable WoW64 tests absent explicit 32-bit build output
Rather than having the 64-bit build assume that it lives in
out\{Debug,Release}_x64 and that it can find 32-bit build output in
out\{Debug,Release}, require the location of 32-bit build output to be
provided explicitly via the CRASHPAD_TEST_32_BIT_OUTPUT environment
variable. If this variable is not set, 64-bit tests that require 32-bit
test build output will dynamically disable themselves at runtime.
In order for this to work, a new DISABLED_TEST() macro is added to
support dynamically disabled tests. gtest does not have its own
first-class support for this
(https://groups.google.com/d/topic/googletestframework/Nwh3u7YFuN4,
https://github.com/google/googletest/issues/490) so this local solution
is used instead.
For tests via Crashpad’s own build\run_tests.py, which is how Crashpad’s
own buildbots and trybots invoke tests, CRASHPAD_TEST_32_BIT_OUTPUT is
set to a locaton compatible with the paths expected for the GYP-based
build. No test coverage is lost on Crashpad’s own buildbots and trybots.
For Crashpad tests in Chromium’s buildbots and trybots, this environment
variable will not be set, causing these tests to be dynamically
disabled.
Bug: crashpad:203, chromium:743139, chromium:777924
Change-Id: I3c0de2bf4f835e13ed5a4adda5760d6fed508126
Reviewed-on: https://chromium-review.googlesource.com/739795
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-10-26 13:48:01 -04:00
|
|
|
|
|
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(DisabledTestGtestEnvironment);
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
} // namespace test
|
|
|
|
|
} // namespace crashpad
|
|
|
|
|
|
|
|
|
|
//! \brief Displays a message about a test being disabled, and returns early.
|
|
|
|
|
//!
|
|
|
|
|
//! gtest only provides a mechanism for tests to be disabled statically, by
|
|
|
|
|
//! prefixing test case names or test names with `DISABLED_`. When it is
|
|
|
|
|
//! necessary to disable tests dynamically, gtest provides no assistance. This
|
|
|
|
|
//! macro displays a message about the disabled test and returns early. The
|
|
|
|
|
//! dynamically disabled test will also be displayed during gtest global test
|
|
|
|
|
//! environment tear-down before the test executable exits.
|
|
|
|
|
//!
|
|
|
|
|
//! This macro may only be invoked from the context of a gtest test.
|
|
|
|
|
//!
|
|
|
|
|
//! There’s a long-standing <a
|
|
|
|
|
//! href="https://groups.google.com/d/topic/googletestframework/Nwh3u7YFuN4">gtest
|
|
|
|
|
//! feature request</a> to provide this functionality directly in gtest, but
|
|
|
|
|
//! since it hasn’t been implemented, this macro provides a local mechanism to
|
|
|
|
|
//! achieve it.
|
|
|
|
|
#define DISABLED_TEST() \
|
|
|
|
|
do { \
|
|
|
|
|
::crashpad::test::DisabledTestGtestEnvironment::Get()->DisabledTest(); \
|
|
|
|
|
return; \
|
|
|
|
|
} while (false)
|
|
|
|
|
|
|
|
|
|
#endif // CRASHPAD_TEST_GTEST_DISABLED_H_
|