2017-07-05 18:23:32 -07:00
|
|
|
// Copyright 2017 The Crashpad Authors. All rights reserved.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
2017-09-08 12:49:55 -07:00
|
|
|
#include "snapshot/elf/elf_image_reader.h"
|
2017-07-05 18:23:32 -07:00
|
|
|
|
|
|
|
#include <dlfcn.h>
|
Read either DT_HASH or DT_GNU_HASH to determine the size of DT_SYMTAB
Without the section headers for the symbol table, there's no direct way
to calculate the number of entries in the table.
DT_HASH and DT_GNU_HASH are auxiliary tables that are designed to make
symbol lookup faster. DT_HASH is the original and is theoretically
mandatory. DT_GNU_HASH is the new-and-improved, but is more complex.
In practice, however, an Android build (at least vs. API 16) has only
DT_HASH, and not DT_GNU_HASH, and a Fuchsia build has only DT_GNU_HASH
but not DT_HASH. So, both are tried.
This change does not actually use the data in these tables to improve
the speed of symbol lookup, but instead only uses them to correctly
terminate the linear search.
DT_HASH contains the total number of symbols in the symbol table fairly
directly because there is an entry for each symbol table entry in the
hash table, so the number is the same.
DT_GNU_HASH regrettably does not. Instead, it's necessary to walk the
buckets and chain structure to find the largest entry.
DT_GNU_HASH doesn't appear in any "real" documentation that I'm aware
of, other than the binutils code (at least as far as I know). Some
more-and-less-useful references:
- https://flapenguin.me/2017/04/24/elf-lookup-dt-hash/
- https://flapenguin.me/2017/05/10/elf-lookup-dt-gnu-hash/
- http://deroko.phearless.org/dt_gnu_hash.txt
- https://sourceware.org/ml/binutils/2006-10/msg00377.html
Change-Id: I7cfc4372f29efc37446f0931d22a1f790e44076f
Bug: crashpad:213, crashpad:196
Reviewed-on: https://chromium-review.googlesource.com/876879
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2018-01-30 14:30:50 -08:00
|
|
|
#include <link.h>
|
2017-07-05 18:23:32 -07:00
|
|
|
#include <unistd.h>
|
|
|
|
|
|
|
|
#include "base/logging.h"
|
2017-07-29 17:18:12 -04:00
|
|
|
#include "build/build_config.h"
|
2017-07-05 18:23:32 -07:00
|
|
|
#include "gtest/gtest.h"
|
2018-01-25 13:37:12 -08:00
|
|
|
#include "test/multiprocess_exec.h"
|
2018-01-19 14:03:34 -08:00
|
|
|
#include "test/process_type.h"
|
Read either DT_HASH or DT_GNU_HASH to determine the size of DT_SYMTAB
Without the section headers for the symbol table, there's no direct way
to calculate the number of entries in the table.
DT_HASH and DT_GNU_HASH are auxiliary tables that are designed to make
symbol lookup faster. DT_HASH is the original and is theoretically
mandatory. DT_GNU_HASH is the new-and-improved, but is more complex.
In practice, however, an Android build (at least vs. API 16) has only
DT_HASH, and not DT_GNU_HASH, and a Fuchsia build has only DT_GNU_HASH
but not DT_HASH. So, both are tried.
This change does not actually use the data in these tables to improve
the speed of symbol lookup, but instead only uses them to correctly
terminate the linear search.
DT_HASH contains the total number of symbols in the symbol table fairly
directly because there is an entry for each symbol table entry in the
hash table, so the number is the same.
DT_GNU_HASH regrettably does not. Instead, it's necessary to walk the
buckets and chain structure to find the largest entry.
DT_GNU_HASH doesn't appear in any "real" documentation that I'm aware
of, other than the binutils code (at least as far as I know). Some
more-and-less-useful references:
- https://flapenguin.me/2017/04/24/elf-lookup-dt-hash/
- https://flapenguin.me/2017/05/10/elf-lookup-dt-gnu-hash/
- http://deroko.phearless.org/dt_gnu_hash.txt
- https://sourceware.org/ml/binutils/2006-10/msg00377.html
Change-Id: I7cfc4372f29efc37446f0931d22a1f790e44076f
Bug: crashpad:213, crashpad:196
Reviewed-on: https://chromium-review.googlesource.com/876879
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2018-01-30 14:30:50 -08:00
|
|
|
#include "test/scoped_module_handle.h"
|
|
|
|
#include "test/test_paths.h"
|
2017-07-05 18:23:32 -07:00
|
|
|
#include "util/file/file_io.h"
|
2017-09-12 16:49:35 -07:00
|
|
|
#include "util/misc/address_types.h"
|
2018-02-15 10:38:36 -08:00
|
|
|
#include "util/misc/elf_note_types.h"
|
2017-07-05 18:23:32 -07:00
|
|
|
#include "util/misc/from_pointer_cast.h"
|
2018-01-19 14:03:34 -08:00
|
|
|
#include "util/process/process_memory_native.h"
|
|
|
|
|
|
|
|
#if defined(OS_FUCHSIA)
|
2018-07-30 15:50:17 -07:00
|
|
|
#include <lib/zx/process.h>
|
2018-01-19 14:03:34 -08:00
|
|
|
|
|
|
|
#include "base/fuchsia/fuchsia_logging.h"
|
|
|
|
|
|
|
|
#elif defined(OS_LINUX) || defined(OS_ANDROID)
|
|
|
|
|
2018-04-03 15:01:44 -07:00
|
|
|
#include "test/linux/fake_ptrace_connection.h"
|
2018-01-19 14:03:34 -08:00
|
|
|
#include "util/linux/auxiliary_vector.h"
|
|
|
|
#include "util/linux/memory_map.h"
|
|
|
|
|
|
|
|
#else
|
|
|
|
|
|
|
|
#error Port.
|
|
|
|
|
|
|
|
#endif // OS_FUCHSIA
|
2017-07-05 18:23:32 -07:00
|
|
|
|
|
|
|
extern "C" {
|
2019-02-11 10:59:14 -05:00
|
|
|
__attribute__((visibility("default"))) void ElfImageReaderTestExportedSymbol() {
|
|
|
|
}
|
2017-07-05 18:23:32 -07:00
|
|
|
} // extern "C"
|
|
|
|
|
|
|
|
namespace crashpad {
|
|
|
|
namespace test {
|
|
|
|
namespace {
|
|
|
|
|
2018-01-19 14:03:34 -08:00
|
|
|
|
|
|
|
#if defined(OS_FUCHSIA)
|
|
|
|
|
2018-07-30 15:50:17 -07:00
|
|
|
void LocateExecutable(const ProcessType& process,
|
2018-01-19 14:03:34 -08:00
|
|
|
ProcessMemory* memory,
|
|
|
|
VMAddress* elf_address) {
|
|
|
|
uintptr_t debug_address;
|
2018-07-30 15:50:17 -07:00
|
|
|
zx_status_t status = process->get_property(
|
|
|
|
ZX_PROP_PROCESS_DEBUG_ADDR, &debug_address, sizeof(debug_address));
|
2018-01-19 14:03:34 -08:00
|
|
|
ASSERT_EQ(status, ZX_OK)
|
|
|
|
<< "zx_object_get_property: ZX_PROP_PROCESS_DEBUG_ADDR";
|
2018-01-25 13:37:12 -08:00
|
|
|
// Can be 0 if requested before the loader has loaded anything.
|
|
|
|
EXPECT_NE(debug_address, 0u);
|
2018-01-19 14:03:34 -08:00
|
|
|
|
|
|
|
constexpr auto k_r_debug_map_offset = offsetof(r_debug, r_map);
|
|
|
|
uintptr_t map;
|
|
|
|
ASSERT_TRUE(
|
|
|
|
memory->Read(debug_address + k_r_debug_map_offset, sizeof(map), &map))
|
|
|
|
<< "read link_map";
|
|
|
|
|
|
|
|
constexpr auto k_link_map_addr_offset = offsetof(link_map, l_addr);
|
|
|
|
uintptr_t base;
|
|
|
|
ASSERT_TRUE(memory->Read(map + k_link_map_addr_offset, sizeof(base), &base))
|
|
|
|
<< "read base";
|
|
|
|
|
|
|
|
*elf_address = base;
|
|
|
|
}
|
|
|
|
|
|
|
|
#elif defined(OS_LINUX) || defined(OS_ANDROID)
|
|
|
|
|
2018-04-03 15:01:44 -07:00
|
|
|
void LocateExecutable(PtraceConnection* connection,
|
2018-01-19 14:03:34 -08:00
|
|
|
ProcessMemory* memory,
|
|
|
|
VMAddress* elf_address) {
|
2017-07-05 18:23:32 -07:00
|
|
|
AuxiliaryVector aux;
|
2018-04-03 15:01:44 -07:00
|
|
|
ASSERT_TRUE(aux.Initialize(connection));
|
2017-07-05 18:23:32 -07:00
|
|
|
|
2017-09-12 16:49:35 -07:00
|
|
|
VMAddress phdrs;
|
2017-07-05 18:23:32 -07:00
|
|
|
ASSERT_TRUE(aux.GetValue(AT_PHDR, &phdrs));
|
|
|
|
|
|
|
|
MemoryMap memory_map;
|
2018-04-03 15:01:44 -07:00
|
|
|
ASSERT_TRUE(memory_map.Initialize(connection));
|
2017-07-11 08:59:24 -07:00
|
|
|
const MemoryMap::Mapping* phdr_mapping = memory_map.FindMapping(phdrs);
|
|
|
|
ASSERT_TRUE(phdr_mapping);
|
2018-12-17 14:27:46 -08:00
|
|
|
auto possible_mappings = memory_map.FindFilePossibleMmapStarts(*phdr_mapping);
|
|
|
|
ASSERT_EQ(possible_mappings->Count(), 1u);
|
|
|
|
*elf_address = possible_mappings->Next()->range.Base();
|
2017-07-05 18:23:32 -07:00
|
|
|
}
|
|
|
|
|
2018-01-19 14:03:34 -08:00
|
|
|
#endif // OS_FUCHSIA
|
|
|
|
|
2017-12-05 11:21:14 -08:00
|
|
|
void ExpectSymbol(ElfImageReader* reader,
|
|
|
|
const std::string& symbol_name,
|
|
|
|
VMAddress expected_symbol_address) {
|
2017-09-12 16:49:35 -07:00
|
|
|
VMAddress symbol_address;
|
|
|
|
VMSize symbol_size;
|
2017-07-05 18:23:32 -07:00
|
|
|
ASSERT_TRUE(
|
2017-12-05 11:21:14 -08:00
|
|
|
reader->GetDynamicSymbol(symbol_name, &symbol_address, &symbol_size));
|
2017-07-05 18:23:32 -07:00
|
|
|
EXPECT_EQ(symbol_address, expected_symbol_address);
|
|
|
|
|
|
|
|
EXPECT_FALSE(
|
2017-12-05 11:21:14 -08:00
|
|
|
reader->GetDynamicSymbol("notasymbol", &symbol_address, &symbol_size));
|
2017-07-05 18:23:32 -07:00
|
|
|
}
|
|
|
|
|
2018-01-25 13:37:12 -08:00
|
|
|
void ReadThisExecutableInTarget(ProcessType process,
|
|
|
|
VMAddress exported_symbol_address) {
|
2017-07-05 18:23:32 -07:00
|
|
|
#if defined(ARCH_CPU_64_BITS)
|
|
|
|
constexpr bool am_64_bit = true;
|
|
|
|
#else
|
|
|
|
constexpr bool am_64_bit = false;
|
|
|
|
#endif // ARCH_CPU_64_BITS
|
|
|
|
|
2018-01-19 14:03:34 -08:00
|
|
|
ProcessMemoryNative memory;
|
|
|
|
ASSERT_TRUE(memory.Initialize(process));
|
2017-12-05 11:21:14 -08:00
|
|
|
ProcessMemoryRange range;
|
|
|
|
ASSERT_TRUE(range.Initialize(&memory, am_64_bit));
|
|
|
|
|
2018-01-19 14:03:34 -08:00
|
|
|
VMAddress elf_address;
|
2018-04-03 15:01:44 -07:00
|
|
|
#if defined(OS_LINUX) || defined(OS_ANDROID)
|
|
|
|
FakePtraceConnection connection;
|
|
|
|
ASSERT_TRUE(connection.Initialize(process));
|
|
|
|
LocateExecutable(&connection, &memory, &elf_address);
|
|
|
|
#elif defined(OS_FUCHSIA)
|
|
|
|
LocateExecutable(process, &memory, &elf_address);
|
|
|
|
#endif
|
2018-01-19 14:03:34 -08:00
|
|
|
ASSERT_NO_FATAL_FAILURE();
|
|
|
|
|
2017-12-05 11:21:14 -08:00
|
|
|
ElfImageReader reader;
|
|
|
|
ASSERT_TRUE(reader.Initialize(range, elf_address));
|
|
|
|
|
2018-01-25 13:37:12 -08:00
|
|
|
ExpectSymbol(
|
|
|
|
&reader, "ElfImageReaderTestExportedSymbol", exported_symbol_address);
|
2017-12-05 11:21:14 -08:00
|
|
|
|
|
|
|
ElfImageReader::NoteReader::Result result;
|
|
|
|
std::string note_name;
|
|
|
|
std::string note_desc;
|
|
|
|
ElfImageReader::NoteReader::NoteType note_type;
|
2018-11-06 13:19:06 -08:00
|
|
|
VMAddress desc_addr;
|
2017-12-05 11:21:14 -08:00
|
|
|
|
|
|
|
std::unique_ptr<ElfImageReader::NoteReader> notes = reader.Notes(-1);
|
2018-11-06 13:19:06 -08:00
|
|
|
while ((result = notes->NextNote(
|
|
|
|
¬e_name, ¬e_type, ¬e_desc, &desc_addr)) ==
|
2017-12-05 11:21:14 -08:00
|
|
|
ElfImageReader::NoteReader::Result::kSuccess) {
|
|
|
|
}
|
|
|
|
EXPECT_EQ(result, ElfImageReader::NoteReader::Result::kNoMoreNotes);
|
|
|
|
|
|
|
|
notes = reader.Notes(0);
|
2018-11-06 13:19:06 -08:00
|
|
|
EXPECT_EQ(notes->NextNote(¬e_name, ¬e_type, ¬e_desc, &desc_addr),
|
2017-12-05 11:21:14 -08:00
|
|
|
ElfImageReader::NoteReader::Result::kNoMoreNotes);
|
|
|
|
|
|
|
|
// Find the note defined in elf_image_reader_test_note.S.
|
|
|
|
constexpr uint32_t kCrashpadNoteDesc = 42;
|
2018-02-15 10:38:36 -08:00
|
|
|
notes = reader.NotesWithNameAndType(
|
|
|
|
CRASHPAD_ELF_NOTE_NAME, CRASHPAD_ELF_NOTE_TYPE_SNAPSHOT_TEST, -1);
|
2018-11-06 13:19:06 -08:00
|
|
|
ASSERT_EQ(notes->NextNote(¬e_name, ¬e_type, ¬e_desc, &desc_addr),
|
2017-12-05 11:21:14 -08:00
|
|
|
ElfImageReader::NoteReader::Result::kSuccess);
|
2018-02-15 10:38:36 -08:00
|
|
|
EXPECT_EQ(note_name, CRASHPAD_ELF_NOTE_NAME);
|
|
|
|
EXPECT_EQ(note_type,
|
|
|
|
implicit_cast<unsigned int>(CRASHPAD_ELF_NOTE_TYPE_SNAPSHOT_TEST));
|
2017-12-05 11:21:14 -08:00
|
|
|
EXPECT_EQ(note_desc.size(), sizeof(kCrashpadNoteDesc));
|
|
|
|
EXPECT_EQ(*reinterpret_cast<decltype(kCrashpadNoteDesc)*>(¬e_desc[0]),
|
|
|
|
kCrashpadNoteDesc);
|
|
|
|
|
2018-11-06 13:19:06 -08:00
|
|
|
EXPECT_EQ(notes->NextNote(¬e_name, ¬e_type, ¬e_desc, &desc_addr),
|
2017-12-05 11:21:14 -08:00
|
|
|
ElfImageReader::NoteReader::Result::kNoMoreNotes);
|
2017-07-05 18:23:32 -07:00
|
|
|
}
|
|
|
|
|
2018-01-25 13:37:37 -08:00
|
|
|
void ReadLibcInTarget(ProcessType process,
|
|
|
|
VMAddress elf_address,
|
|
|
|
VMAddress getpid_address) {
|
2017-07-05 18:23:32 -07:00
|
|
|
#if defined(ARCH_CPU_64_BITS)
|
|
|
|
constexpr bool am_64_bit = true;
|
|
|
|
#else
|
|
|
|
constexpr bool am_64_bit = false;
|
|
|
|
#endif // ARCH_CPU_64_BITS
|
|
|
|
|
2018-01-19 14:03:34 -08:00
|
|
|
ProcessMemoryNative memory;
|
|
|
|
ASSERT_TRUE(memory.Initialize(process));
|
2017-12-05 11:21:14 -08:00
|
|
|
ProcessMemoryRange range;
|
|
|
|
ASSERT_TRUE(range.Initialize(&memory, am_64_bit));
|
|
|
|
|
|
|
|
ElfImageReader reader;
|
|
|
|
ASSERT_TRUE(reader.Initialize(range, elf_address));
|
|
|
|
|
2018-01-25 13:37:37 -08:00
|
|
|
ExpectSymbol(&reader, "getpid", getpid_address);
|
2017-07-05 18:23:32 -07:00
|
|
|
}
|
|
|
|
|
2018-01-19 14:03:34 -08:00
|
|
|
TEST(ElfImageReader, MainExecutableSelf) {
|
2018-01-25 13:37:12 -08:00
|
|
|
ReadThisExecutableInTarget(
|
|
|
|
GetSelfProcess(),
|
|
|
|
FromPointerCast<VMAddress>(ElfImageReaderTestExportedSymbol));
|
2018-01-19 14:03:34 -08:00
|
|
|
}
|
|
|
|
|
2018-01-25 13:37:12 -08:00
|
|
|
CRASHPAD_CHILD_TEST_MAIN(ReadExecutableChild) {
|
|
|
|
VMAddress exported_symbol_address =
|
|
|
|
FromPointerCast<VMAddress>(ElfImageReaderTestExportedSymbol);
|
|
|
|
CheckedWriteFile(StdioFileHandle(StdioStream::kStandardOutput),
|
|
|
|
&exported_symbol_address,
|
|
|
|
sizeof(exported_symbol_address));
|
|
|
|
CheckedReadFileAtEOF(StdioFileHandle(StdioStream::kStandardInput));
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
class ReadExecutableChildTest : public MultiprocessExec {
|
2017-07-05 18:23:32 -07:00
|
|
|
public:
|
2018-01-25 13:37:12 -08:00
|
|
|
ReadExecutableChildTest() : MultiprocessExec() {}
|
2017-07-05 18:23:32 -07:00
|
|
|
|
|
|
|
private:
|
2018-01-25 13:37:12 -08:00
|
|
|
void MultiprocessParent() {
|
|
|
|
// This read serves two purposes -- on Fuchsia, the loader may have not
|
|
|
|
// filled in debug address as soon as the child process handle is valid, so
|
|
|
|
// this causes a wait at least until the main() of the child, at which point
|
|
|
|
// it will always be valid. Secondarily, the address of the symbol to be
|
|
|
|
// looked up needs to be communicated.
|
|
|
|
VMAddress exported_symbol_address;
|
|
|
|
CheckedReadFileExactly(ReadPipeHandle(),
|
|
|
|
&exported_symbol_address,
|
|
|
|
sizeof(exported_symbol_address));
|
|
|
|
ReadThisExecutableInTarget(ChildProcess(), exported_symbol_address);
|
|
|
|
}
|
2017-07-05 18:23:32 -07:00
|
|
|
};
|
|
|
|
|
|
|
|
TEST(ElfImageReader, MainExecutableChild) {
|
|
|
|
ReadExecutableChildTest test;
|
2018-01-25 13:37:12 -08:00
|
|
|
test.SetChildTestMainFunction("ReadExecutableChild");
|
2017-07-05 18:23:32 -07:00
|
|
|
test.Run();
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(ElfImageReader, OneModuleSelf) {
|
2018-01-25 13:37:37 -08:00
|
|
|
Dl_info info;
|
|
|
|
ASSERT_TRUE(dladdr(reinterpret_cast<void*>(getpid), &info)) << "dladdr:"
|
|
|
|
<< dlerror();
|
|
|
|
VMAddress elf_address = FromPointerCast<VMAddress>(info.dli_fbase);
|
|
|
|
ReadLibcInTarget(
|
|
|
|
GetSelfProcess(), elf_address, FromPointerCast<VMAddress>(getpid));
|
|
|
|
}
|
|
|
|
|
|
|
|
CRASHPAD_CHILD_TEST_MAIN(ReadLibcChild) {
|
|
|
|
// Get the address of libc (by using getpid() as a representative member),
|
|
|
|
// and also the address of getpid() itself, and write them to the parent, so
|
|
|
|
// it can validate reading this information back out.
|
|
|
|
Dl_info info;
|
|
|
|
EXPECT_TRUE(dladdr(reinterpret_cast<void*>(getpid), &info))
|
|
|
|
<< "dladdr:" << dlerror();
|
|
|
|
VMAddress elf_address = FromPointerCast<VMAddress>(info.dli_fbase);
|
|
|
|
VMAddress getpid_address = FromPointerCast<VMAddress>(getpid);
|
|
|
|
|
|
|
|
CheckedWriteFile(StdioFileHandle(StdioStream::kStandardOutput),
|
|
|
|
&elf_address,
|
|
|
|
sizeof(elf_address));
|
|
|
|
CheckedWriteFile(StdioFileHandle(StdioStream::kStandardOutput),
|
|
|
|
&getpid_address,
|
|
|
|
sizeof(getpid_address));
|
|
|
|
CheckedReadFileAtEOF(StdioFileHandle(StdioStream::kStandardInput));
|
|
|
|
return 0;
|
2017-07-05 18:23:32 -07:00
|
|
|
}
|
|
|
|
|
2018-01-25 13:37:37 -08:00
|
|
|
class ReadLibcChildTest : public MultiprocessExec {
|
2017-07-05 18:23:32 -07:00
|
|
|
public:
|
2018-01-25 13:37:37 -08:00
|
|
|
ReadLibcChildTest() : MultiprocessExec() {}
|
2017-07-05 18:23:32 -07:00
|
|
|
~ReadLibcChildTest() {}
|
|
|
|
|
|
|
|
private:
|
2018-01-25 13:37:37 -08:00
|
|
|
void MultiprocessParent() {
|
|
|
|
VMAddress elf_address, getpid_address;
|
|
|
|
CheckedReadFileExactly(ReadPipeHandle(), &elf_address, sizeof(elf_address));
|
|
|
|
CheckedReadFileExactly(
|
|
|
|
ReadPipeHandle(), &getpid_address, sizeof(getpid_address));
|
|
|
|
ReadLibcInTarget(ChildProcess(), elf_address, getpid_address);
|
|
|
|
}
|
2017-07-05 18:23:32 -07:00
|
|
|
};
|
|
|
|
|
|
|
|
TEST(ElfImageReader, OneModuleChild) {
|
|
|
|
ReadLibcChildTest test;
|
2018-01-25 13:37:37 -08:00
|
|
|
test.SetChildTestMainFunction("ReadLibcChild");
|
2017-07-05 18:23:32 -07:00
|
|
|
test.Run();
|
|
|
|
}
|
|
|
|
|
Read either DT_HASH or DT_GNU_HASH to determine the size of DT_SYMTAB
Without the section headers for the symbol table, there's no direct way
to calculate the number of entries in the table.
DT_HASH and DT_GNU_HASH are auxiliary tables that are designed to make
symbol lookup faster. DT_HASH is the original and is theoretically
mandatory. DT_GNU_HASH is the new-and-improved, but is more complex.
In practice, however, an Android build (at least vs. API 16) has only
DT_HASH, and not DT_GNU_HASH, and a Fuchsia build has only DT_GNU_HASH
but not DT_HASH. So, both are tried.
This change does not actually use the data in these tables to improve
the speed of symbol lookup, but instead only uses them to correctly
terminate the linear search.
DT_HASH contains the total number of symbols in the symbol table fairly
directly because there is an entry for each symbol table entry in the
hash table, so the number is the same.
DT_GNU_HASH regrettably does not. Instead, it's necessary to walk the
buckets and chain structure to find the largest entry.
DT_GNU_HASH doesn't appear in any "real" documentation that I'm aware
of, other than the binutils code (at least as far as I know). Some
more-and-less-useful references:
- https://flapenguin.me/2017/04/24/elf-lookup-dt-hash/
- https://flapenguin.me/2017/05/10/elf-lookup-dt-gnu-hash/
- http://deroko.phearless.org/dt_gnu_hash.txt
- https://sourceware.org/ml/binutils/2006-10/msg00377.html
Change-Id: I7cfc4372f29efc37446f0931d22a1f790e44076f
Bug: crashpad:213, crashpad:196
Reviewed-on: https://chromium-review.googlesource.com/876879
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
2018-01-30 14:30:50 -08:00
|
|
|
#if defined(OS_FUCHSIA)
|
|
|
|
|
|
|
|
// crashpad_snapshot_test_both_dt_hash_styles is specially built and forced to
|
|
|
|
// include both .hash and .gnu.hash sections. Linux, Android, and Fuchsia have
|
|
|
|
// different defaults for which of these sections should be included; this test
|
|
|
|
// confirms that we get the same count from both sections.
|
|
|
|
//
|
|
|
|
// TODO(scottmg): Investigation in https://crrev.com/c/876879 resulted in
|
|
|
|
// realizing that ld.bfd does not emit a .gnu.hash that is very useful for this
|
|
|
|
// purpose when there's 0 exported entries in the module. This is not likely to
|
|
|
|
// be too important, as there's little need to look up non-exported symbols.
|
|
|
|
// However, it makes this test not work on Linux, where the default build uses
|
|
|
|
// ld.bfd. On Fuchsia, the only linker in use is lld, and it generates the
|
|
|
|
// expected .gnu.hash. So, for now, this test is only run on Fuchsia, not Linux.
|
|
|
|
//
|
|
|
|
// TODO(scottmg): Separately, the location of the ELF on Android needs some
|
|
|
|
// work, and then the test could also be enabled there.
|
|
|
|
TEST(ElfImageReader, DtHashAndDtGnuHashMatch) {
|
|
|
|
base::FilePath module_path =
|
|
|
|
TestPaths::BuildArtifact(FILE_PATH_LITERAL("snapshot"),
|
|
|
|
FILE_PATH_LITERAL("both_dt_hash_styles"),
|
|
|
|
TestPaths::FileType::kLoadableModule);
|
|
|
|
// TODO(scottmg): Remove this when upstream Fuchsia bug ZX-1619 is resolved.
|
|
|
|
// See also explanation in build/run_tests.py for Fuchsia .so files.
|
|
|
|
module_path = module_path.BaseName();
|
|
|
|
ScopedModuleHandle module(
|
|
|
|
dlopen(module_path.value().c_str(), RTLD_LAZY | RTLD_LOCAL));
|
|
|
|
ASSERT_TRUE(module.valid()) << "dlopen " << module_path.value() << ": "
|
|
|
|
<< dlerror();
|
|
|
|
|
|
|
|
#if defined(ARCH_CPU_64_BITS)
|
|
|
|
constexpr bool am_64_bit = true;
|
|
|
|
#else
|
|
|
|
constexpr bool am_64_bit = false;
|
|
|
|
#endif // ARCH_CPU_64_BITS
|
|
|
|
|
|
|
|
ProcessMemoryNative memory;
|
|
|
|
ASSERT_TRUE(memory.Initialize(GetSelfProcess()));
|
|
|
|
ProcessMemoryRange range;
|
|
|
|
ASSERT_TRUE(range.Initialize(&memory, am_64_bit));
|
|
|
|
|
|
|
|
struct link_map* lm = reinterpret_cast<struct link_map*>(module.get());
|
|
|
|
|
|
|
|
ElfImageReader reader;
|
|
|
|
ASSERT_TRUE(reader.Initialize(range, lm->l_addr));
|
|
|
|
|
|
|
|
VMSize from_dt_hash;
|
|
|
|
ASSERT_TRUE(reader.GetNumberOfSymbolEntriesFromDtHash(&from_dt_hash));
|
|
|
|
|
|
|
|
VMSize from_dt_gnu_hash;
|
|
|
|
ASSERT_TRUE(reader.GetNumberOfSymbolEntriesFromDtGnuHash(&from_dt_gnu_hash));
|
|
|
|
|
|
|
|
EXPECT_EQ(from_dt_hash, from_dt_gnu_hash);
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif // OS_FUCHSIA
|
|
|
|
|
2017-07-05 18:23:32 -07:00
|
|
|
} // namespace
|
|
|
|
} // namespace test
|
|
|
|
} // namespace crashpad
|