crashpad/util/process/process_memory_linux.h

56 lines
1.7 KiB
C
Raw Normal View History

// Copyright 2017 The Crashpad Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#ifndef CRASHPAD_UTIL_PROCESS_PROCESS_MEMORY_LINUX_H_
#define CRASHPAD_UTIL_PROCESS_PROCESS_MEMORY_LINUX_H_
#include <sys/types.h>
#include <functional>
#include <string>
#include "base/files/scoped_file.h"
#include "util/misc/address_types.h"
#include "util/process/process_memory.h"
namespace crashpad {
class PtraceConnection;
//! \brief Accesses the memory of another Linux process.
linux: ProcessReader can own ProcessMemoryLinux without unique_ptr There’s no reason for ProcessReader to own its ProcessMemoryLinux via std::unique_ptr<>. This was discovered in a trunk Clang build, during which a -Wdelete-non-virtual-dtor warning was produced (since Clang r312167). The warning is not produced by earlier Clang versions or by GCC because the “delete” happens in a system header, <memory>, when performed by std::unique_ptr<>. Although ownership via std::unique_ptr<> is no longer used, ProcessMemoryLinux is marked “final” because it ought to be. In file included from ../../snapshot/linux/process_reader.cc:15: In file included from ../../snapshot/linux/process_reader.h:21: In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/7.2.0/../../include/c++/7.2.0/memory:80: /usr/bin/../lib/gcc/x86_64-linux-gnu/7.2.0/../../include/c++/7.2.0/bits/unique_ptr.h:78:2: error: delete called on non-final 'crashpad::ProcessMemoryLinux' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor] delete __ptr; ^ /usr/bin/../lib/gcc/x86_64-linux-gnu/7.2.0/../../include/c++/7.2.0/bits/unique_ptr.h:268:4: note: in instantiation of member function 'std::default_delete<crashpad::ProcessMemoryLinux>::operator()' requested here get_deleter()(__ptr); ^ ../../snapshot/linux/process_reader.cc:169:16: note: in instantiation of member function 'std::unique_ptr<crashpad::ProcessMemoryLinux, std::default_delete<crashpad::ProcessMemoryLinux> >::~unique_ptr' requested here ProcessReader::ProcessReader() ^ 1 error generated. Change-Id: Ibe9671db429262aca12bbfdf457c8f72cad2f358 Reviewed-on: https://chromium-review.googlesource.com/738530 Reviewed-by: Dave Bort <dbort@google.com> Commit-Queue: Mark Mentovai <mark@chromium.org>
2017-10-25 14:26:29 -04:00
class ProcessMemoryLinux final : public ProcessMemory {
public:
explicit ProcessMemoryLinux(PtraceConnection* connection);
ProcessMemoryLinux(const ProcessMemoryLinux&) = delete;
ProcessMemoryLinux& operator=(const ProcessMemoryLinux&) = delete;
~ProcessMemoryLinux();
//! \brief Returns the input pointer with any non-addressing bits, such as
//! tags removed.
VMAddress PointerToAddress(VMAddress address) const;
private:
ssize_t ReadUpTo(VMAddress address, size_t size, void* buffer) const override;
std::function<ssize_t(VMAddress, size_t, void*)> read_up_to_;
base::ScopedFD mem_fd_;
bool ignore_top_byte_;
};
} // namespace crashpad
#endif // CRASHPAD_UTIL_PROCESS_PROCESS_MEMORY_LINUX_H_